nimo23
nimo23
You mean "Inline Picker / Date-time" ? That is really not the same. Look at the picture above! You see the different? With the above "Timepicker" you can select "TIME"...
I think, using parameters within the constructor to differentiate between these different criterion types are an alternative. For example, creat enum within PnLCriterion: ``` enum PnLType{ NetPnL, GrossPnL, NetProfit, GrossProfit,...
We must change the names in any ways, because it's not consistent. Another alternative to have a consistent naming scheme, is to remove the `Net`-Prefix and only leave the `Gross`-Prefix....
@team172011 please check if my solution is right. For example: If `startIndex = 0 and finishIndex = 10`, then the tradingRecord should only contain trades within the range of 0...
I came up with two versions, however, I don't know which one, if any, is correct: The version from this PR: ``` if (!tradingRecord.isClosed() && finishIndex == barSeries.getEndIndex()) { .....
>If so, I might volunteer to add to JUnit test cases for these We need junit test cases for those sensible parts of the `RecursiveCachedIndicator` instead. **And yes, I did...
I did not finished this PR (for example, in BaseBar: replace function with numType, adapt test cases, ..). @team172011 So far, I only want to know/discuss, if this PR is...
Maybe it would be sufficient to change the `BarSeries`-constructors (and do **not** change the `Bar`-constructors with all its testing classes..). The Bar-Constructors can have the Num Type from its BarSeries....
Using https://github.com/ta4j/ta4j/blob/9a3bb213364424f92ce0fd9501f47e45b2c33c21/ta4j-core/src/main/java/org/ta4j/core/BarSeriesManager.java#L158 with: - `startIndex` > series.getBeginIndex() - `endIndex` < barSeries.getEndIndex() returns a tradingRecord within `startIndex` and `endIndex`, however, all those Criteria which calculates stuff within the whole barSeries (from...
@team172011 This PR is finished and ready for review.