nimo23

Results 246 comments of nimo23

@team172011 After all I think, `dividedBy` is better than `divide` because it makes the **direction** clearer ("divided by" expresses `a / b`). At least, `multipliedBy` can be renamed because telling...

>It is very clear what Num#multipliedBy(Num other) means. Yes, it's very clear. But `multiply` is also very clear, isn't it? We should use the same **naming scheme** and if we...

>So active branches that are yet to merge might have large number of diffs and reviewing everything is tedious. Tedious? We shouldn't bother about it, firstly, because laziness shouldn't be...

@team172011 please delete https://github.com/ta4j/ta4j/blob/develop/ta4j-core/src/main/java/org/ta4j/core/criteria/NumberOfConsecutiveWinningPositionsCriterion.java from the repo, because the new `NumberOfConsecutivePositionsCriterion` replaces it.

@team172011 after this PR is merged, we can use the `AnalysisCriterion.PositionFilter` as well for other criteria to handle both sides within one criterion instead of creating two classes..

You can change the default to: ``` public static DecimalNum valueOf(BigDecimal val) { return new DecimalNum(val, DEFAULT_PRECISION); } ``` and add another method with: ``` public static DecimalNum valueOf(BigDecimal val,...

FYI: https://blogs.oracle.com/javamagazine/four-common-pitfalls-of-the-bigdecimal-class-and-how-to-avoid-them#anchor_2

no need for this. I can use Tern.java.

code completion only works if I rename my js-file to a ts-file. **For js-files, I have no code completion.** I have this settings: - Preferences->..->Typescript->"Use Salsa as JavaScript Inference" (enabled)...

>I have implemented it myself after seeing no response here If you have already implemented it, it would be nice to create a PR to share with the community.