Nicklas Larsson

Results 286 comments of Nicklas Larsson

> Before merging this PR, it might need a new title, since it isn't a new workflow. Done. > Also, is the existing workflow file name still appropriate for what...

Wouldn't it be better to – in the process of creating the tarball – create and add a simple textfile containing the git commit? Configure then can try get info...

> Wouldn't it be better to – in the process of creating the tarball – create and add a simple textfile containing the git commit? Configure then can try get...

> Yes it is improvement, but core_modules_with_last_commit patch/JSON file **is not required file by default**. The generated patch/json file is needed in a tarball release, but should be included **in**...

#3435 attempt to address this for tarball releases with `GRASS_HEADERS_GIT_HASH` and `GRASS_HEADERS_GIT_DATE`, without the need for introducing new environmental variables and even further complicate the code. Next step will be...

> Next step will be to update configure and/or `utils/mkhtml.py` to read, if needed, from distributed json file. @tmszi I have not yet studied the code, but if we package...

With #3435 and #3437, resulting in Git related data included in tarball too, consistent builds are enabled with/without Git and also across platforms. This will be available with GRASS GIS...

Updated with fixed tests. `if test "$GIT" != "no" ; then` only checks for presence of `git` the command/program.

Added `include/VERSION_GIT`-file generation script. (Initially I planned to have this code in the workflow file, but decided it is better to have it in source).