Nicklas Larsson
Nicklas Larsson
Beware, pre-commit settings should be in sync with https://github.com/OSGeo/grass/blob/main/.github/workflows/python-code-quality.yml and other eventual settings.
In general, I'd say code changes that can be updated as is, should go to separate PR(s) (if it isn't literally only one or two minor changes), which will possibly...
I have no practical experience setting up code coverage. Just some notes: > For gunittest, use coverage.py directly. To use it at a basic level, it is simply equivalent to...
Finally, the Periodic update workflow kicked in right when it should have :).
The checks weren’t triggered, had to close and re-open. https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs
> Is there any objections or real potential breakages that can happen, that wouldn't be caught in before a release candidate? If not, I'll merge this in a close future...
> > I put this up as a "proof of concept". > > for some kind of a "general" switch to clang? Would that really be such a bad thing?...
> > Would that really be such a bad thing? > > not a bad thing :-) > > Just a case of curiosity I think the CI runner should...
The Labeler went nearly all-in for this. @echoix Do you perhaps know why?
> ...merging main in it meant a lot of changes in everywhere.... That sounds plausible.