Nicklas Larsson

If I understand this correctly, the standalone installer for Windows works, while the OSGeo4W distribution does not. Given that is the case, I assume this is caused by conflicting dependencies....

> > If I understand this correctly, the standalone installer for Windows works, while the OSGeo4W distribution does not. > > @nilason, the standalone WinGRASS GRASS-GIS 8.4.0 works, while GRASS-GIS...

> @nilason there was a typo: WinGRASS GRASS-GIS 8.4.0 installs only libgomp-1.dll (not libomp.dll as previously incorrectly written). > > Anyway, I've also checked now that GRASS-GIS 8.3.2 from OSGeo4W,...

Technically, as being C11, we can make use of [_Atomic](https://en.cppreference.com/w/c/language/atomic.html) for the counter, if that could be part of a solution.

> Where do you think the md5sum should come from? Now it is locally generated, but there is one uploaded from the CI. I was thinking of adding an instruction...

Now I added a instructions for download of *.sha256 file and running `sha256sum` with it. The `*.sha256` file will, and should, be uploaded to server (along with the *.md5sum file)....

It doesn't look correct, you add a specifier `lld` before the macro `PRId64` which should add that (platform specific) specifier in the first place. To be sure the definition of...

`db_get_login()` was deprecated (in favour of `db_get_login2()`) in 2015 with the 7.8.0 release: https://github.com/OSGeo/grass/commit/da399c52637ee5c81228459fa374a114c8fef06c I think this (8.5) may the moment to drop it.

(The CodeQL CI failure is unrelated to changes of this PR.)

I gather this issue originates from `cppcheck`, this is the relevant part for this: ``` cppcheck imagery/i.smap/model.c ... imagery/i.smap/model.c:158:43: warning: Invalid log() argument nr 1. The value is 0 but...