Nicklas Larsson
Nicklas Larsson
You should probably also add `Closes https://trac.macports.org/ticket/70298` to commit message.
It is only GRASS 8.5+ that uses the CBLAS interface. This code needs to be GRASS version aware, off the head I'm not sure what would work for Addons. In...
> What about [OSGeo/grass@d5bb442#diff-1df0e75a8f47991f0c38f6ff94dadf2f0d2203321bf6346136360b099ff0b086L40](https://github.com/OSGeo/grass/commit/d5bb442d7b121861928a37842e05e5265a980427#diff-1df0e75a8f47991f0c38f6ff94dadf2f0d2203321bf6346136360b099ff0b086L40), where HAVE_G2C_H is used. Could #ifndef HAVE_G2C_H be appropriate? I realised now that `HAVE_CBLAS_H` may have already be set also before 8.5 (not reflecting current changes...
Another related issue: `EODAG` python package is listed as requirement, but I see in the code that the `i.eodag` addon is also required.
> How about adding `requirements.txt` files, at least for Python? > > See e.g. our `v.out.geojson` addon which contains a `python-requirements:` target to run `pip`: > > https://github.com/mundialis/v.out.geojson/blob/main/Makefile > >...
> The download button on the mac site should directly lead to the binary. I agree.