Nicklas Larsson

Results 286 comments of Nicklas Larsson

> I tested this PR by creating `include/VERSION_GIT` and than removing `.git` directory (which is not located in tarball): > > ``` > checking for include/VERSION_GIT... yes > fatal: not...

Any thoughts on this one, @landam , @neteler , anyone?

I wonder if not the patch to ctypesgen: https://github.com/OSGeo/grass/blob/c700a8a923cd8e7b0e49e5abab3a2ae313eccaef/python/libgrass_interface_generator/ctypesgen/libraryloader.py#L325-L329 which adds all PATH directories to dll loading, could cause this and other Windows issues like #2101 . I never felt...

> > I never felt good with that patch. > > What would to be changed to find out? I'm not quite sure yet. I've been tinkering on a GRASS...

I manually followed the test case to be able to better see what's going on: ```bash g.region res=10 res3=10 n=80 s=0 w=0 e=120 b=0 t=50 r3.mapcalc expression="map_1 = 100" r3.mapcalc...

> These are the results of r3.univar -g map=test_flowaccum, which indicates that the problem perhaps either lies with r3.univar and/or the expected test results. Alternatively, if indeed max and range...

I'm glad this issue is up to discussion. As a committer I have (too often) experienced what is really sticking out in the statistics you provide: "No feedback" – ending...

> > @HuidaeCho Are you planning to merge this PR? > > Do you know how to re-run _expired_ failed tests without making a small commit just to revive them?...

For more recently run jobs you can re-run, by going to "Details" and in the upper right side you have: ![screen](https://github.com/OSGeo/grass/assets/14186207/976ca5d7-2542-4cd4-a24b-5d37160dc22b)

As far as I understand libdeflate is not a "replacement" to zlib, meaning this is not only a question of configuration. See example from [GDAL](https://gdal.org/development/building_from_source.html#deflate) : https://github.com/OSGeo/gdal/commit/01b3560c90b3a7ae005dd67c69eae85262adcec3