Nicklas Larsson
Nicklas Larsson
There shouldn’t be any reason to cast `-1` to `off_t` when directly comparing against the results of `lseek`. Not a big deal, but just adds clutter (in my opinion).
> > What do you think about the message? I think that everyone needs that comment about what this refers to, not only the translators. > > I am not...
> > > What do you think about the message? I think that everyone needs that comment about what this refers to, not only the translators. > > > >...
I have at the moment no further suggestions, objections. @cwhite911, @wenzeslaus, I hand over to you.
> Wow: > > With the new PR [#6579](https://github.com/OSGeo/grass/pull/6579) , github pipeline tests will fail if test data have been generated with `nc_basic_spm_grass7` or `nc_spm_08_grass7` which have an EPSG code...
`grass_parson` needs to be added as dependency to: https://github.com/OSGeo/grass/blob/c855d997fd574d1b3d8cd7afdaff087a1ca5ffd6/general/CMakeLists.txt#L25
> Do I understand correctly that the following in Microsoft documentation is a typo? > > > Also, `snprintf()` includes one more character in the output because it doesn't null-terminate...
> When you say deprecate, is it only in some docs, or by using super strict compiler flags we can make our builds in CI fail for it, to not...
Among Addons only [r.sim.water.mp](https://github.com/OSGeo/grass-addons/blob/a0e37beaf0ce8a4cc6ec615b6d3d40e39f9d725f/src/raster/r.sim.water.mp/output.c#L37) make use of G_snprintf(), whereas [i.wavelet](https://github.com/OSGeo/grass-addons/blob/a0e37beaf0ce8a4cc6ec615b6d3d40e39f9d725f/src/imagery/i.wavelet/main.c#L203) is the only one using snprintf().
> * the file that used to host G_snprintf is changed to use snprintf This is not correct, it still uses `vsnprintf()`, but I have removed the unnecessary fix (adding...