Nicklas Larsson
Nicklas Larsson
> Was it almost ready? It _is_ ready.
Is this solved by #4256?
#4256 is merged and backported to 8.4, @ninsbl can this be closed?
> A dependency yet missing? > > From the CI log: > > ``` > ... > configure: error: *** couldn't find libpng-config > Error: Process completed with exit code...
> Was there a logic in the new order of the OSGeo4W dependencies, was it in the patch that it was in that order? It's not alphabetical neither, I don't...
@landam Let us continue the OpenMP issue from ML here. Extracting from the logs from CI and https://wingrass.fsv.cvut.cz reveals the following: **Win CI runner (main)** ``` checking for omp.h... yes...
osgeo4w installs libomp.dll: https://github.com/jef-n/OSGeo4W/blob/f8ada2fe6637b1abde0a361fa8b5b2089a82e33d/src/grass/osgeo4w/package.sh#L104 which is probably why configure hooks up on it. Perhaps ```diff -/mingw64/bin/libgomp-1.dll +/mingw64/bin/libomp.dll ``` in https://github.com/OSGeo/grass/blob/3f61cd7625f728ff0795023e97529e2ec896c5cc/mswindows/osgeo4w/package.sh#L127 could be the solution?
At least OpenMP issues need to be addressed for 8.4.1, I’ll add backport label for this PR as not to miss this.
OpenMP related fix (hopefully) is added with https://github.com/jef-n/OSGeo4W/commit/06d4d83912dffccd638417338f43f03f4f84c15b and https://github.com/jef-n/OSGeo4W/commit/c678c71d080e5c33e8cb64b12386be2ca4b6c54a.