Nicklas Larsson

I'm not sure what tool reports this as out-of-bounds array access. However, `kk` can't possibly be negative: https://github.com/OSGeo/grass/blob/2e55b158af94127c520d384978405d1da561f534/imagery/i.atcorr/computations.cpp#L108-L113 make it clear it must be between 0 and 82.

> @marisn or @nilason, if you agree that the issue is the test, I can split this into two PRs to get the new code in now and add the...

> I would perhaps just ignore it since it is CR, although it seems that according to a [SE comment](https://superuser.com/questions/439440/did-mac-os-lion-switch-to-using-line-feeds-lf-n-for-line-breaks-instead-of), still in 2012, you could get CR: > > >...

> I did not see the issue with G_getl2 in #3850 and I don't see with a quick look now. The idea was to merge this PR before #3850 to...

See also https://github.com/OSGeo/grass/blob/60f67276fbee985042f9fc571f824bb2c863ffbe/raster3d/r3.showdspf/README#L10-L15

How about to move `r3.showdspf` to https://github.com/OSGeo/grass-addons or delete it?

> I'd suggest to remove it as being entirely outdated. And it's still available from older versions. @lbartoletti Are you up to change this to remove the module?

I believe it should be enough to initialize at the declaration at line 92: `int threads = 1;`. `parm.nproc->answer ` is by default `"1"`: https://github.com/OSGeo/grass/blob/3f30f1bb59f79d18074a3527d9101200c0975214/lib/gis/parser_standard_options.c#L757-L770 Something the static analyser apparently...

> A user can specify `nprocs` as a 0 or negative value. In this case, the default value will be replaced. Overall, we still need to handle this situation. Indeed,...

> I am open to any choices below. > > 1. Raise error when `nprocs < 1` > 2. Raise error when `nprocs = 0`, and set `threads = nprocs...