Nicklas Larsson

Results 286 comments of Nicklas Larsson

@cwhite911 could this be closed?

The macOS 14 runner failed on rev-bumped `ncarg` and `gerris`. The reasons are independent of this PR, see [ncarg ticket](https://trac.macports.org/ticket/67455) [gerris ticket](https://trac.macports.org/ticket/69726).

> I support this `proj` refactor. Great! > I suggest that you drop changes for messed up ports `gerris` and `ncarg`, file separate PR's or track tickets for them later....

I have now rebased. The failing CI is caused by failure to build `gerris` on macos-14 reported with https://trac.macports.org/ticket/69726, which is **not** related to this PR. Please, could we move...

> Macports requires that all CI checks pass. If this is technically necessary to for all CIs to pass, to enable merge of a PR, I'll gladly drop `gerris` from...

> > Patching configure was the easy part. > > LOL! Someday you can explain to me what _that_ means. ```diff --- configure.ac.orig 2013-12-06 16:51:21 +++ configure.ac 2024-07-01 13:38:23 @@...

I resorted to add cflag `-Wno-error=incompatible-function-pointer-types` to `gerris` for Clang builds on macOS 14+. This is obviously not a future proof solution, but a proper fix isn't trivial.

@stromnov As maintainer for the PROJ ports, please notify your opinion on this.

> It looks good to me. Great! Please go ahead and merge, this change is long awaited.

@stromnov I have now rebased and added update to PROJ 9.5.0, which was just recently released.