Nicklas Larsson

> > I did what I could to help out on this feature (that I really want) with what I'm good with, the CI. I made them as code suggestions...

> Can I use yamllint for formatting? No. > Looks like, it only _checks_, not _format_. Yes, it is only a linter ("checker") not formatter.

I have just tried this PR out and you've come a long way! I hit some obstacles configuring/building on Mac, if you reached the point to receive a "pre-review" I'm...

Don't think these issues are platform specific, so... First issue was building with `-DWITH_LIBPNG=OFF` which causes build error: ``` [ 13%] Linking C shared library ../gisbase/lib/libgrass_pngdriver.dylib cd /dev/grass/build/lib && /opt/local/bin/cmake...

You can add `"16" "15" ` to `FindPostgreSQL.cmake` line 105 (variable `PostgreSQL_KNOWN_VERSIONS`)

There is no Findzstd.cmake file, only `libzstd.pc`. This I solved by "borrowing" the file from GDAL https://github.com/OSGeo/gdal/blob/master/cmake/modules/packages/FindZSTD.cmake and the following changes: ```diff diff --git a/cmake/modules/CheckDependentLibraries.cmake b/cmake/modules/CheckDependentLibraries.cmake index 9d234af783..49eaa99043 100644 ---...

lib/symbol failed to link, complaining of missing G_malloc etc. This I solved by: ```diff diff --git a/lib/CMakeLists.txt b/lib/CMakeLists.txt index d079bb9207..8f6fcadcac 100644 --- a/lib/CMakeLists.txt +++ b/lib/CMakeLists.txt @@ -186,7 +186,7 @@ build_library_in_subdir(...

The final issue I had was with FFTW, I have both `dfftw.h` and `fftw3.h` installed, this I solved with : ```diff diff --git a/lib/gmath/fft.c b/lib/gmath/fft.c index c0dea7b7d0..79749b2161 100644 --- a/lib/gmath/fft.c...

> This is interesting because `WITH_LIBPNG=OFF` by default and it works on my Linux. `read_png.c` and `write_png.c` are excluded for `WITH_LIBPNG=OFF` and their functions shouldn't be called. Just committed a...

> I think [9d4d22c](https://github.com/OSGeo/grass/commit/9d4d22c234a84fb0f4d892ccaa0a383d7b270a1d) is a right thing to do, but in a separate PR. What do you think? Yes, it is most probably correct, why keep the prototypes with...