Nigel Megitt
Nigel Megitt
This could be a Python2 issue, to be re-reviewed when we have migrated to Python3.
Agreed to remove SMPTE.
I just did a search on the code, in hope more than anything. Turns out that there are still lots of references to smpte... I don't think this is essential...
Comments have now been added to the code, in v2.1.1.
Looks like the proxy handling has changed in autobahn/twisted. Very rudimentary/ugly fix at 0f9d961 - if it doesn't affect anything else, should probably move this change to the proxy parsing...
I've just re-reviewed this. Some thoughts: * No unit tests on this code => not merge-able yet. * Otherwise it is somewhat useful for resequencing at known times, but does...
I've narrowed down the cause of this, after much painful digging. See https://github.com/python-hyper/hyperlink/commit/d26814c074c6f9787e62af907df17fbd68fde615#commitcomment-22765690 My explanation: * Twisted uses `hyperlink.URL` * `hyperlink.URL.from_text()` now calls `_textcheck()` on the path segment looking for...
Addition to the above: https://github.com/python-hyper/hyperlink/issues/16 is an example where this has already been raised as an issue.
Pull request #453 passes local tests, by requiring hyperlink < 17.2.0.
Looks like this issue might close itself when the hyperlink project makes their next release - they expect this bug to be fixed by then.