ebu-tt-live-toolkit icon indicating copy to clipboard operation
ebu-tt-live-toolkit copied to clipboard

Published 20 hours ago • verified publisher icon ebu

Issue 485 remote clock

Open nigelmegitt opened this issue 7 years ago • 2 comments

Fix #485 by allowing a remote URL to be provided, which is dereferenced and the returned ISO date processed and used.

nigelmegitt avatar May 09 '18 17:05 nigelmegitt

Coverage Status

Coverage decreased (-0.3%) to 84.845% when pulling 7e33412a217cc02941e9cac2705c1676405edfe5 on issue-485-remote-clock into 46c19515b2d0461a77f142eb24c98d4f234ba648 on release/2.1.2.

coveralls avatar May 09 '18 17:05 coveralls

I've just re-reviewed this. Some thoughts:

  • No unit tests on this code => not merge-able yet.
  • Otherwise it is somewhat useful for resequencing at known times, but does not in itself ensure that the extracted segments timings are locked to the intended times. All it does is makes the requests for segments at correct times: it does not specify the segment times being requested to match. That in turn creates a buggy behaviour where there are edge effects around the beginning and end of each segment extracted, when converting to EBU-TT-D and serving as live subtitles in fragmented MP4.

Conclusion: more work needed.

nigelmegitt avatar Jul 16 '19 14:07 nigelmegitt