ebu-tt-live-toolkit icon indicating copy to clipboard operation
ebu-tt-live-toolkit copied to clipboard

Issue 483 encoding errors

Open nigelmegitt opened this issue 7 years ago • 3 comments

Fix #483 by using codecs.open and ignoring encoding errors. Seems a bit scary/naughty somehow - I would prefer to fix it upstream if I knew the cause.

nigelmegitt avatar May 08 '18 15:05 nigelmegitt

Coverage Status

Coverage increased (+0.01%) to 85.206% when pulling 1890be21c220a00d707e52ee2dd37e84809248fd on issue-483-encoding-errors into 46c19515b2d0461a77f142eb24c98d4f234ba648 on release/2.1.2.

coveralls avatar May 08 '18 15:05 coveralls

Whilst this doesn't break anything, it also doesn't seem to solve the problem, whose cause is currently unknown.

nigelmegitt avatar Jun 20 '18 11:06 nigelmegitt

This could be a Python2 issue, to be re-reviewed when we have migrated to Python3.

nigelmegitt avatar Jul 16 '19 14:07 nigelmegitt