Nicolas Grekas

Results 733 comments of Nicolas Grekas
trafficstars

This relies on the child class calling the parent class. I'd suggest using the `@afterClass` annotation instead (and making the method public). This will provide better ordering also because this...

That failure is a false-positive so we can ignore it.

I realized that there's another issue: we made the method public, which will break classes that override the method but keep it protected. Let's revert...

I suggest going with your initial PR: calling ensureKernelShutdown in teardownAfterClass Can you submit it? Then let's discuss about possible impacts there.

It'd say $requestDecision and $decisionReasons. (One could also use addReason to explain why they decided to ACCEPT the request, isn't it?)

Ah sorry I missed the high/low-deps failures. The reason why this fails is because of the cross-packages deps. Do you think you can find a test case that'd fit in...