SmartThingsEdgeDrivers icon indicating copy to clipboard operation
SmartThingsEdgeDrivers copied to clipboard

Add support for combination button/switch devices

Open nickolas-deboom opened this issue 1 year ago • 4 comments

Type of Change

  • [ ] WWST Certification Request
    • If this is your first time contributing code:
      • [ ] I have reviewed the README.md file
      • [ ] I have reviewed the CODE_OF_CONDUCT.md file
      • [ ] I have signed the CLA
    • [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • [ ] Bug fix
  • [x] New feature
  • [ ] Refactor

Checklist

  • [x] I have performed a self-review of my code
  • [x] I have commented my code in hard-to-understand areas
  • [ ] I have verified my changes by testing with a device or have communicated a plan for testing
  • [x] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This PR adds support for combination button/switch device types that are now being released. These changes were prompted by new Inovelli devices that feature button and switch functionality. Note that some additional discussion is needed on how these devices should be configured before this PR can move forward. Also note that these changes rely on PR 1547 and PR 1548.

Note that these changes used to be in PR 1549 but that PR was closed due to complications with rebasing against PR's 1547 and 1548.

Summary of Completed Tests

We do not have any devices yet but test_matter_button_switch_mcd.lua was created to verify the functionality of these types of composed devices.

nickolas-deboom avatar Aug 23 '24 17:08 nickolas-deboom

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] avatar Aug 23 '24 17:08 github-actions[bot]

Channel deleted.

github-actions[bot] avatar Aug 23 '24 17:08 github-actions[bot]

Test Results

   61 files  ±0    379 suites  +2   0s :stopwatch: ±0s 1 826 tests +2  1 826 :white_check_mark: +2  0 :zzz: ±0  0 :x: ±0  3 207 runs  +5  3 207 :white_check_mark: +5  0 :zzz: ±0  0 :x: ±0 

Results for commit 2749fe0f. ± Comparison against base commit 773d5a73.

github-actions[bot] avatar Aug 23 '24 17:08 github-actions[bot]

File Coverage
All files 95% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 96% :white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 2749fe0fe3dc097bd325a68cf785fc8b3d41f21e

github-actions[bot] avatar Aug 23 '24 17:08 github-actions[bot]

Closing in favor of https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/1663

nickolas-deboom avatar Oct 02 '24 14:10 nickolas-deboom