Modify to limit user setting and values that may cause mismatching

[HunsupJung]

Check all that apply

Type of Change

• [ ] WWST Certification Request
  • If this is your first time contributing code:
    • [ ] I have reviewed the README.md file
    • [ ] I have reviewed the CODE_OF_CONDUCT.md file
    • [ ] I have signed the CLA
  • [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
• [x] Bug fix
• [ ] New feature
• [ ] Refactor

Checklist

• [ ] I have performed a self-review of my code
• [ ] I have commented my code in hard-to-understand areas
• [ ] I have verified my changes by testing with a device or have communicated a plan for testing
• [ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

The max limit of heating and cooling setpoint should be set to 39 or less because the value of 40 or more in the driver is considered Fahrenheit. Conversely, since a value of 40 or less is regarded as Celsius, it should not be possible to set the value below 40 degrees in the plugin in the Fahrenheit state. In summary, it should not be set above 40 degrees Celsius to below 5 degrees Celsius(40 degrees Fahrenheit).

Summary of Completed Tests

Ticket

IOTE-4490

[github-actions[bot]]

Channel deleted.

[github-actions[bot]]

Test Results

   62 files    383 suites   0s :stopwatch: 1 862 tests 1 862 :white_check_mark: 0 :zzz: 0 :x: 3 249 runs  3 249 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 3efcb653.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

File	Coverage
All files	81%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua	83%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua	42%	:x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 3efcb653a2b929bda319d0527dbadc50ee29cc50

[HunsupJung]

Please refer to the following ticket https://smartthings.atlassian.net/browse/IOTE-4490

[nickolas-deboom]

Hi @HunsupJung , I agree with these changes, however I have a PR here that implements dynamic constraints for matter-thermostat and matter-sensor that does many of the same things as your PR (in terms of the new handlers for the heating and cooling setpoint limits). Would you mind waiting until that PR is merged (should be by tomorrow) and then applying your changes for these min and max values afterwards?

[nickolas-deboom]

Hi @HunsupJung , I agree with these changes, however I have a PR here that implements dynamic constraints for matter-thermostat and matter-sensor that does many of the same things as your PR (in terms of the new handlers for the heating and cooling setpoint limits). Would you mind waiting until that PR is merged (should be by tomorrow) and then applying your changes for these min and max values afterwards?

Hey @HunsupJung, PR 1619 was merged into main and so now if you rebase you will be able to apply the changes for the temp limits on top of that.

[HunsupJung]

@nickolas-deboom Thank you for your explanation. I updated this PR

[nickolas-deboom]

I left one comment but other than that the changes look great! Thanks for making the update.

[HunsupJung]

@nickolas-deboom this PR can be closed by your PR. Thank you for your effort. 👍