clients [PM-20041] Marking Task as complete

🎟️ Tracking

PM-20041 Server PR: https://github.com/bitwarden/server/pull/5896

📔 Objective

When a cipher has an associated pending credential task and the user has updated the password, mark the task as complete.

In turn this will mark all notifications associated with the task as deleted. See the server side PR.

📸 Screenshots

May 28 '25 20:05 nick-livefront

Checkmarx One – Scan Summary & Details – 32bf78a7-2f2d-43c7-a0b4-a70d35740176

Great job, no security vulnerabilities found in this Pull Request

May 28 '25 20:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Project coverage is 36.89%. Comparing base (7a1bb81) to head (02b3b91). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...risk-callout/at-risk-password-callout.component.ts	0.00%	8 Missing :warning:
...ipher-form/services/default-cipher-form.service.ts	92.85%	0 Missing and 1 partial :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14980      +/-   ##
==========================================
+ Coverage   36.88%   36.89%   +0.01%     
==========================================
  Files        3232     3232              
  Lines       93554    93573      +19     
  Branches    14077    14082       +5     
==========================================
+ Hits        34503    34525      +22     
+ Misses      57621    57612       -9     
- Partials     1430     1436       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

:package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

May 28 '25 20:05 codecov[bot]

@shane-melton I had to fix a test from merging in main. 0daf3d1

Jun 13 '25 19:06 nick-livefront

@shane-melton I merged https://github.com/bitwarden/clients/pull/15247 into this branch so all of the changes are together. Just an FYI that it will need another review pass.

Jun 19 '25 20:06 nick-livefront

@shane-melton Another update after Kyra's round of QA. 1ee8b07, I missed the description which accounts for the number of at risk passwords