clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-8381] Assign collections

Open nick-livefront opened this issue 1 year ago â€ĸ 2 comments

Stacked on top of @gbubemismith's https://github.com/bitwarden/clients/pull/9507 and the same PR as #9757 but with a clean git history 😓

đŸŽŸī¸ Tracking

PM-8381

📔 Objective

  • Add "Assign Collections" screen
  • Moving a cipher into an organization and assigned to at least one collection
  • Reassigning collections within an organization
  • The select & multi-select that are shown in the designs do not appear to be available yet.

📸 Screenshots

Move cipher to org reassign collections

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

nick-livefront avatar Jun 27 '24 14:06 nick-livefront

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 31.64%. Comparing base (fd93c76) to head (d642753).

Files Patch % Lines
...assign-collections/assign-collections.component.ts 0.00% 27 Missing :warning:
...ult/src/components/assign-collections.component.ts 0.00% 6 Missing :warning:
apps/browser/src/popup/app-routing.module.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9854      +/-   ##
==========================================
- Coverage   31.66%   31.64%   -0.03%     
==========================================
  Files        2620     2621       +1     
  Lines       78251    78279      +28     
  Branches    14676    14682       +6     
==========================================
- Hits        24780    24773       -7     
- Misses      51590    51625      +35     
  Partials     1881     1881              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 27 '24 14:06 codecov[bot]

Logo Checkmarx One – Scan Summary & Details – 78c76731-9b71-4e01-a12c-04166949047e

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Angular_Improper_Type_Pipe_Usage /libs/vault/src/cipher-form/components/additional-options/additional-options-section.component.html: 11 Attack Vector
MEDIUM Client_Privacy_Violation /libs/auth/src/angular/input-password/input-password.component.html: 14 Attack Vector
MEDIUM Client_Privacy_Violation /libs/auth/src/angular/input-password/input-password.component.html: 44 Attack Vector

github-actions[bot] avatar Jun 27 '24 14:06 github-actions[bot]

This looks good to go! I'd suggest holding off merging until @gbubemismith's parent PR is merged as its currently undergoing QA. (unless you feel differently @gbubemismith)

I'll wait to merge in until after @gbubemismith's work is merged that way we don't have a single huge PR.

nick-livefront avatar Jul 01 '24 19:07 nick-livefront

@nick-livefront I merged mine to the main; this should be good once the merge conflicts are addressed.

gbubemismith avatar Jul 12 '24 21:07 gbubemismith

@Jingo88 @shane-melton Rebased on top of main after @gbubemismith's merge

nick-livefront avatar Jul 16 '24 14:07 nick-livefront