nicegamer7

Results 124 comments of nicegamer7

I'm converting this PR to a draft, as it will need to be amended after #163.

I've made it so that the ANNOUNCE_ADVANCEMENTS gamerule on the world the player is travelling to gets set to false if wasn't already, then after updating the player's advancements it's...

There is a new Paper PR which may affect the Advancement sharable, see PaperMC/Paper#3454. If this PR gets merged and ends up affecting the behaviour of the sharable, we'd probably...

I just cleaned up this PR, redoing some bits and making the commits more specific. The biggest difference is that the advancement sharable no longer needs a custom serializer. I...

I just rebased this PR onto `main` so that it's up to date, although, the tests need to be adjusted to account for the new sharables. And as requested, I'm...

I... did not think of that... Thanks for bringing that to my attention. With regards to datapacks, there's currently no way for MV to interact with them. So at this...

Here's a new build that should be a *bit* more efficient, and it includes a simple attempt at fixing the XP exploit described above. ~~Multiverse-Inventories-4.2.2-SNAPSHOT.jar.zip~~ (new build below)

And once more, a new build with another attempt at fixing the XP exploit. edit: the exploit is fixed :) [Multiverse-Inventories-4.2.2-SNAPSHOT.jar.zip](https://github.com/Multiverse/Multiverse-Inventories/files/5884485/Multiverse-Inventories-4.2.2-SNAPSHOT.jar.zip)

Thanks for testing @reediculous456! I'm glad you found this issue, and as ben said, if you have steps to reproduce that would be very helpful.

I haven't checked, but I'm pretty sure the notifications are client side. If that's the case, there's almost nothing that can be done. If I'm wrong, we'll need to propose...