Ni Ze

Results 14 comments of Ni Ze

IMO, It looks like a good strategy that persisting all runtime config to local when you update one of them. You can see all config.

```java void setMaxTopicLength(int maxLength); int getMaxTopicLength(); ``` IMO, Put those two method into **ClientConfig** will be better. MQConsumer,LitePullConsumer and MQConsumerInner contains code about send/consume message only. Set/get config should use...

> Member Maybe DefaultLitePullConsumer.commit(final Set messageQueues, boolean persist) can meet your needs.

@BurningCN some conflicts happen in DefaultMessageStore, should merge from develop firstly.

> are you looking to send traces to zipkin with rocketmq or trace application usage of rocketmq? > […](#) > On Mon, Jun 3, 2019, 3:40 PM toohandsome ***@***.***> wrote:...

BrokerAddress can be used as a router, I do not get why do you need brokerName.

What situation will use this gray release allocate strategy? can you give a case? people who use this ability must use this strategy before gray, and change back (or modify...

ResponseCode,MQClientAPIImpl,DefaultMQPullConsumerImpl also need to be corrected.

IMO, the channel close event lost and still can not elect master if method > controller.electMaster failed.