rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

#fix spelling mistakes about 'unknown'

Open chunyizanchi opened this issue 2 years ago • 6 comments

“UNKNOWN” in LocalTransactionState spell error

chunyizanchi avatar Mar 14 '22 17:03 chunyizanchi

1334 line in DefaultMQProducerImpl also need to be corrected

chunyizanchi avatar Mar 15 '22 06:03 chunyizanchi

ResponseCode,MQClientAPIImpl,DefaultMQPullConsumerImpl also need to be corrected.

ni-ze avatar Mar 17 '22 01:03 ni-ze

Codecov Report

Merging #3989 (80d0c4c) into develop (03c5a3d) will decrease coverage by 0.16%. The diff coverage is 33.33%.

@@              Coverage Diff              @@
##             develop    #3989      +/-   ##
=============================================
- Coverage      47.95%   47.78%   -0.17%     
+ Complexity      5004     4981      -23     
=============================================
  Files            633      633              
  Lines          42520    42528       +8     
  Branches        5571     5573       +2     
=============================================
- Hits           20391    20323      -68     
- Misses         19633    19703      +70     
- Partials        2496     2502       +6     
Impacted Files Coverage Δ
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 13.86% <0.00%> (ø)
...lient/impl/consumer/DefaultMQPullConsumerImpl.java 29.76% <0.00%> (ø)
.../apache/rocketmq/common/protocol/ResponseCode.java 0.00% <ø> (ø)
...mq/client/impl/producer/DefaultMQProducerImpl.java 45.21% <33.33%> (ø)
...ocketmq/client/producer/LocalTransactionState.java 100.00% <100.00%> (ø)
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) :arrow_down:
...rocketmq/broker/filtersrv/FilterServerManager.java 20.00% <0.00%> (-14.29%) :arrow_down:
.../org/apache/rocketmq/store/PutMessageSpinLock.java 85.71% <0.00%> (-14.29%) :arrow_down:
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) :arrow_down:
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (-9.38%) :arrow_down:
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03c5a3d...80d0c4c. Read the comment docs.

codecov-commenter avatar Mar 17 '22 02:03 codecov-commenter

Coverage Status

Coverage decreased (-0.07%) to 51.812% when pulling 27bcee7fe03a332e5aa3bce552cf7a17763100a5 on chunyizanchi:develop into c1aeca291ea686a2b7f01ffec30132f5a370a2ab on apache:develop.

coveralls avatar Mar 17 '22 02:03 coveralls

Coverage Status

Coverage increased (+0.2%) to 52.1% when pulling 80d0c4cbcecba074484a17fd373d1c9db6accea8 on chunyizanchi:develop into 818ef2152f8e835cc907557d1e1d3da6705696ac on apache:develop.

coveralls avatar Mar 17 '22 02:03 coveralls

The precise coder.

lwclover avatar Apr 25 '22 05:04 lwclover

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Jun 08 '24 00:06 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar Jun 12 '24 00:06 github-actions[bot]