rocketmq
rocketmq copied to clipboard
[ISSUE #4749] make topic length , consumer group length configable
Make sure set the target branch to develop
What is the purpose of the change
fix https://github.com/apache/rocketmq/issues/4749
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.
- [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
- [x] Run
mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
void setMaxTopicLength(int maxLength);
int getMaxTopicLength();
IMO, Put those two method into ClientConfig will be better. MQConsumer,LitePullConsumer and MQConsumerInner contains code about send/consume message only. Set/get config should use ClientConfig.
I also think that it is a very good choice to put configuration-related variables in ClientConfig. At the same time, it is necessary to consider how to deal with the inconsistency of the MAX_TOPIC_LENGTH between the producer and the consumer.
@francisoliverlee following test would not throw exception
AbstractMessingActivityTest.testValidateTopic()
assertThrows(GrpcProxyException.class, () -> messingActivity.validateTopic(Resource.newBuilder().setName(createString(128)).build()));
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
This PR was closed because it has been inactive for 3 days since being marked as stale.