rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #4559] Remove unnecessary operation of logicsMsgTimestamp

Open BurningCN opened this issue 3 years ago • 3 comments

1.Remove unnecessary operation of logicsMsgTimestamp (issue #4559) 2.When DefaultMessageStore.this.getMessageStoreConfig().isDebugLockEnable() == true, then need scheduleAtFixedRate. 3.Fix typo

BurningCN avatar Jul 07 '22 15:07 BurningCN

Coverage Status

Coverage increased (+0.1%) to 47.712% when pulling 93ac1aed0b7c91c6117a7dbd11e0281d681eb0c3 on BurningCN:patch-4 into 3ee603a49b04c0b602ff8eb45b3ef4330293fba8 on apache:develop.

coveralls avatar Jul 07 '22 17:07 coveralls

Codecov Report

Merging #4573 (93ac1ae) into develop (b136f9b) will increase coverage by 0.17%. The diff coverage is 80.00%.

@@              Coverage Diff              @@
##             develop    #4573      +/-   ##
=============================================
+ Coverage      43.42%   43.59%   +0.17%     
- Complexity      6203     6236      +33     
=============================================
  Files            817      817              
  Lines          57654    57671      +17     
  Branches        7873     7874       +1     
=============================================
+ Hits           25036    25144     +108     
+ Misses         29375    29287      -88     
+ Partials        3243     3240       -3     
Impacted Files Coverage Δ
...ache/rocketmq/store/config/MessageStoreConfig.java 56.76% <66.66%> (ø)
...org/apache/rocketmq/store/DefaultMessageStore.java 52.53% <100.00%> (-0.40%) :arrow_down:
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) :arrow_down:
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 82.85% <0.00%> (-0.48%) :arrow_down:
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 24.51% <0.00%> (-0.08%) :arrow_down:
...he/rocketmq/tools/admin/DefaultMQAdminExtImpl.java 25.88% <0.00%> (-0.07%) :arrow_down:
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (ø)
...a/org/apache/rocketmq/client/impl/MQAdminImpl.java 4.93% <0.00%> (ø)
...apache/rocketmq/tools/admin/DefaultMQAdminExt.java 33.33% <0.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b136f9b...93ac1ae. Read the comment docs.

codecov-commenter avatar Jul 07 '22 17:07 codecov-commenter

@BurningCN some conflicts happen in DefaultMessageStore, should merge from develop firstly.

ni-ze avatar Jul 14 '22 01:07 ni-ze

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Aug 29 '23 00:08 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar Sep 01 '23 00:09 github-actions[bot]