Nicolas Gallagher

Results 470 comments of Nicolas Gallagher

One more task has been added, which is to update the react-native-website docs to include all these new props once all the PRs have been merged.

I think `role` support is missing from `Text` (which appears to support `accessibilityRole`): https://github.com/facebook/react-native/blob/main/Libraries/Text/TextProps.js [This logic](https://github.com/facebook/react-native/blob/main/Libraries/Components/View/View.js#L70) in `View` may need to be moved to a shared place so it can...

> I think role="option" is missing Good spot. I'll add one more task to add `option`.

It maps to nothing AFAICT, but needs to be included in the type for `role`

Any idea why some of the iOS CI jobs failed? Flakey?

No, just waiting on someone to do an internal review. Thanks

@kacieb equivalent functionality in terms of web aria api https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-errormessage

something to note is that the value of aria-errormessage is meant to be the id of an element that contains the error message.

That's great! I don't want to set the precedent that anyone using RNW should be listed in the README though, so I will probably remove everyone except Twitter and Meta.