Nicolas Gallagher

Results 470 comments of Nicolas Gallagher

@Marcoo09 yes please, there is no existing PR. Since this isn't a feature that can simply be aliased to existing styles, you might want to first share how you plan...

The entire flushQueue function had to be commented out https://github.com/necolas/react-native-web/pull/2377/commits/ff72921b57951daf9c37939e9b4be108a1552718#diff-51312a304d660152aec0524a0aca4ca3667cbe604afe7f9c38a88bd8631e962d

I already did something similar to that patch https://github.com/necolas/react-native-web/commit/ff72921b57951daf9c37939e9b4be108a1552718#diff-6ef00d3c5589ec81f1dbc51139b50801209066f362c5d4d4788cd1bebcd0a13b > I did some testing uncommenting that function and updating the code on react-native-web and it seems to work fine That...

OK cool, that looks like it should work then. My only concern is that at any moment an Animated patch could land that breaks web again

> Please provide a unit tests that shows how this behaviour was broken before and how this change resolves it. This will help me understand the goal here and prevent...

Yes, it does. The first thing we do is a flatten, and then extract any animated values that are left

I wonder if this should be a little more complicated in case it's bizarre to have an inputMode set and the showSoftInputOnFocus set. Should the latter be ignored entirely if...

I was thinking more like `inputMode == null ? showSoftInputOnFocus : inputMode !== 'none'`

Andrew pointed me here after I uncovered the same issue. Part of the globalize compiler tool chain can't extract messages from `FormatMessage` elements that are moved as part of babel/react...