react-native icon indicating copy to clipboard operation
react-native copied to clipboard

feat: added enterKeyHint prop to textInput

Open dakshbhardwaj opened this issue 2 years ago • 10 comments

Summary

This adds the enterKeyHint prop to the TextInput component as requested on https://github.com/facebook/react-native/issues/34424, mapping web enterKeyHint types to equivalent returnKeyType values. This PR also updates RNTester TextInputExample in order to facilitate the manual QA.

Open questions

  • What should be the returnType in the case of previous in iOS?

  • what should happen if enterKeyHint and returnKeyType props are passed together?

Changelog

[General] [Added] - Add enterKeyHint prop to TextInput component

Test Plan

  • Open the RNTester app and navigate to the TextInput page
  • Test the TextInput component through the enterKeyHint modes section

dakshbhardwaj avatar Aug 23 '22 15:08 dakshbhardwaj

Hi @dakshbhardwaj!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Aug 23 '22 15:08 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,617,378 +209
android hermes armeabi-v7a 7,031,726 +214
android hermes x86 7,917,537 +203
android hermes x86_64 7,891,228 +204
android jsc arm64-v8a 9,495,010 +140
android jsc armeabi-v7a 8,272,719 +134
android jsc x86 9,432,897 +137
android jsc x86_64 10,025,943 +134

Base commit: de75a7a22eebbe6b7106377bdd697a2d779b91b0 Branch: main

analysis-bot avatar Aug 23 '22 15:08 analysis-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Aug 23 '22 17:08 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Aug 23 '22 17:08 facebook-github-bot

Any idea why some of the iOS CI jobs failed? Flakey?

necolas avatar Aug 23 '22 21:08 necolas

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 23 '22 21:08 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: de75a7a22eebbe6b7106377bdd697a2d779b91b0 Branch: main

analysis-bot avatar Aug 24 '22 07:08 analysis-bot

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 24 '22 18:08 facebook-github-bot

@necolas Thanks for reviewing and approving it. do I need to do anything else?

dakshbhardwaj avatar Aug 26 '22 07:08 dakshbhardwaj

No, just waiting on someone to do an internal review. Thanks

necolas avatar Aug 26 '22 16:08 necolas

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 29 '22 17:08 facebook-github-bot

This pull request was successfully merged by @dakshbhardwaj in 8c882b4f3d361be715c8ec2793c545c687711b5e.

When will my fix make it into a release? | Upcoming Releases

react-native-bot avatar Aug 30 '22 01:08 react-native-bot