Nicolas Gallagher comments

Results 470 comments of


                                            Nicolas Gallagher

[a11y] `role` prop not fully supported on React Native

Thanks! The fix for nested `accessible` elements in iOS should probably live in React Native, since it sounds like the same problem can occur there

feat: mark `inset`, `marginBlock`, `marginInline`, `paddingBlock` and `paddingInline*` props as built-in support

We haven't been using the built in support because all logical styles aren't fully implemented in RN yet, and we had problems in the past with missing desktop support. I'll...

Cannot specify media query in different module - Invalid pseudo or at-rule.

This is a shortcoming of StyleX. See https://github.com/facebook/stylex/issues/724

Support for className and style objects

The solid docs make it clear that style objects are supported - https://docs.solidjs.com/concepts/components/class-style#inline-styling Until the OP can demonstrate beyond doubt that StyleX has a bug with the pattern described in...

Error using vite with RSD: stylex.create'should never be called at runtime.

> https://codesandbox.io/p/github/carloslibardo/website/main "Unable to access this workspace"

Error using vite with RSD: stylex.create'should never be called at runtime.

Is the cjs limitation because we aren't providing mjs exports from the packages?

Error using vite with RSD: stylex.create'should never be called at runtime.

I was on my phone and just mis-tapped the reaction icon

Error using vite with RSD: stylex.create'should never be called at runtime.

Nice work. Would be great to have a PR to add a Vite setup in the repo's app examples

Add basic support for React Server Components

> I'm using a local patch very similar to this and it works quite well for me. Did you have to make any changes? I didn't hear back from @EvanBacon...

Missing `experimental_backgroundImage` style prop support

I think it's best to use that workaround since backgroundImage has always been supported in RNfWeb