Nicolas Gallagher
Nicolas Gallagher
> so the following are valid values: `'1, 1,1, red'`, `1,1, 1,rgb(1,1,0)` No, multiple shadows are separated by commas. You can split on comma to detect multiple shadows and print...
> Splitting with a comma will not work when the shadow color is in rgb or hsl format. Good point! I think eventually a lot of this stuff will move...
I think https://github.com/postcss/postcss would be a better choice. We use it for some value parsing in stylex and react-native-web. Similarly https://colorjs.io/ might be useful for colors. It depends on what...
I don't think we can merge while it includes a change to the `normalize-color` export. It will cause too much churn internally and in the ecosystem. I don't think we...
Yes let's include those too. Thanks
Please can we add unit tests / examples for this?
There's a lot of shared code that we should consolidate, because more properties will be added over time. It probably should go in the StyleSheet directory
There are still a number of issues in this PR that need to be resolved before moving forward: consistency of how the work is done across components, typos in variable...
@mayank-96 please rebase and resolve conflicts again, then @cipolleschi can import it. Thanks!
@mayank-96 ping