Nicholas Bransby-Williams

Results 172 comments of Nicholas Bransby-Williams

@vladmircan I looked at your sample but it just looks like you are just choosing to catch the generic exception by using the FirebaseException base class instead of one of...

No its not expected behavior - I think it would help if you share the full stack trace of the original FirebaseException

are their any breaking changes in here?

> Btw, if you're worried about API changes, consider adding https://github.com/Kotlin/binary-compatibility-validator to the project. We use it for [Kaluga](https://github.com/splendo/kaluga) and it makes it much easier to spot changes Yes we...

The Java SDK has been updated to support latest firebase libs from android bom 32.7.0 and I have removed the jvmMain sources on master

> @nbransby seems publication to maven central failed: https://central.sonatype.com/artifact/dev.gitlive/firebase-java-sdk/versions fixed this now

Found some more time to review... I think we should keep named arguments instead of the EncodeSettings class, revert https://github.com/GitLiveApp/firebase-kotlin-sdk/pull/449#issuecomment-1873835429 and update the examples to some of the places the...

Should all functions that take a builder lambda be marked as inline to avoid the lambda allocation?

Whats the point of the Async nested classes and the Deferred.convert function?

> I dont think that actually avoids anything. We can make the lambda nullable I guess > > > It does, thats the whole point of inline functions