Nicholas Bransby-Williams
Nicholas Bransby-Williams
> Well, to improve async behaviour. For instance, logging or grouping. E.g. As this is just a generic async utility function and unrelated to firebase we shouldn't be introducing it...
> Deferred convert is a mapper for deferred. The Android sdk would return an AndroidDocumentReference and you'd want to return a Kotlin DocumentReference, so it should be mapped. Same with...
Looking good, whats the purpose of the Base... and Native... classes such as NativeQuery and s BaseTransaction? @Daeda88
> Even though with a lot of the code, you kind of want it (e.g., most methods need to encode/decode their values). Base solves this by introducing an abstract class...
> You can't do this with extension functions, because that would defeat the purpose where the common step still needs to be implemented on each method per platform. Are you...
> No, im saying its not correct to do it like that in my opinion, for maintainability reasons. Because if you use that approach, every time something changes to sharedFunction...
> If you want to account for value classes, I would propose to move to interfaces with default implementations, as that sort of meets both criteria (maintainability and maintaining possibility...
No plans yet, but PRs welcome!
its a start would be happy to accept a PR for this but you can also just add this in your code or just call com.google.firebase.messaging.FirebaseMessaging.getInstance() / FIRMessaging.messaging() where you...
Makes total sense, will review the PR now