Nicholas Bransby-Williams
Nicholas Bransby-Williams
Makes sense, glad there is a fix coming 👍
No plans yet, but PRs welcome!
@Daeda88 has your changes to where clauses fixed this issue now?
Looking at the official android sdk, the methods are defined as follows: https://firebase.google.com/docs/reference/android/com/google/firebase/database/FirebaseDatabase#setPersistenceCacheSizeBytes(long) Any reason not to match this?
This PR inspired me to write a section on compatibility with the official firebase android sdk here: https://github.com/GitLiveApp/firebase-kotlin-sdk?tab=readme-ov-file#compatibility-with-the-official-firebase-android-sdk Can we apply those points to this PR?
Also I used the term binary compat a lot when technically I mean source compatibility
> Also moved the `IllegalStateException` thrown when attempting to set new settings after using Firestore into the common code, so that it may be caught properly (before it was impossible...
look like the build failed: `e: file:///home/runner/work/firebase-kotlin-sdk/firebase-kotlin-sdk/firebase-firestore/src/commonMain/kotlin/dev/gitlive/firebase/firestore/firestore.kt:47:17 Unresolved reference: isConfigured `
Js test still failing 😅
It should throw the same exception, can you supply some more details on how to reproduce this?