Nicholas Bransby-Williams

Results 172 comments of Nicholas Bransby-Williams

Yes I am afraid no one has contributed towards the coverage of these modules yet

we'll need to add specific support for reference fields in the serialization support - how do they work with the standard serialization for android or js, aka what is the...

@petea since its only adding the nullability won't existing code still compile meaning its not a breaking change?

> Currently `FirebaseException` can be initialized with a `code` value, however the `code` is only used to build the default Exception message. `FirebaseException` doesn't have any properties on Android: https://developers.google.com/android/reference/com/google/firebase/FirebaseException...

> Did you mean [`FirebaseAuthException`](https://firebase.google.com/docs/reference/android/com/google/firebase/auth/FirebaseAuthException)? Actually I suspect you were referring to the `FirebaseException` in the JS target as that does have a code that's not exposed to match https://firebase.google.com/docs/reference/node/firebase.FirebaseError...

We now support java clientside environments via the https://github.com/GitLiveApp/firebase-java-sdk

No It not possible as its for client-side java environments only - I know some people were using the Java Admin SDK client-side in lieu of a Java SDK so...

I believe this has been fixed in 1.9.0 - please reopen if something is missing

Although your effort is highly appreciated, the secret to getting timely approval on PRs is to produce small ones, this is huge and makes reviewers lose the will to live!...