Nicholas Bransby-Williams

Results 172 comments of Nicholas Bransby-Williams

You need to fork the repository and then push the branch to your fork then you can create a pull request to this repo

OK, yes we should probably support both decoding to a double/long and Timestamp class. For the Timestamp class we would need to create an expect class Timestamp to common layer...

@jonatbergn we would need to just wrap the native types received from the firebase SDKs with our expect/actual version. We would check the expected type during decode and assume we...

Would it be possible for you to add a failing test for this as a PR? Does it work on android?

Hi @PokerAsh no there hasn't been any work done on analytics yet but we do want to add them at some point in the future and PRs are always welcome!

A test need to be added for this once the ios test are running

ios tests are running now so would be great if you could send a PR with a failing test for this

I'm afraid this is becuase we haven't even started to add coverage for the messaging APIs 😢 PRs are very much welcome though!

thanks for reporting, if you can find the time to submit PR with a failing test that would be much appreciated!

Hi @LandryNorris thanks for this PR! After looking through the code I believe it would be best to put this into a separate module, we could use `dev.gitlive.firebase-admin` Reasoning for...