frontend
frontend copied to clipboard
fix(Switches): organise owners
What does this change?
Remove people that have left the organisation. Use groups over individuals where relevant.
Is the owners field relevant, if it most of the time identical to the Switch Group?
Should we have automated checks for github accounts that are no longer inside @guardian?
Does this change need to be reproduced in dotcom-rendering ?
- [X] No
- [ ] Yes (please indicate your plans for DCR Implementation)
Tested
- [ ] Locally
- [ ] On CODE (optional)
Maybe we can hoist the
sellByDate
to anExperiment
?
I think this can be addressed into another PR. I’m not entirely sure how hoisting works in Scala, so let’s pair on it?
This way we can still have experiments expire - and email people when they do, but not need an expiry on switches, which are long lasting.
Worth noting that currently, we will only email individuals or teams that have used the Owner.withEmail
feature. Ones registered with SwitchGroup
or Github will not receive anything. The web engineers and Dotcom platform should still get reminders.
With
owners
- it seems like we're usingSwitchGroup
as a proxy for what team owns a features, but maybe this should be more explicit there?
Yes, I’m not sure what the benefit of this is if this is identical to the Switch’s group…
"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days"
Seen on PROD (merged by @mxdvl 15 minutes and 56 seconds ago)
- Check your changes on www.theguardian.com ✔️
- Keep an eye on the deploy dashboard 📉