dotcom-rendering icon indicating copy to clipboard operation
dotcom-rendering copied to clipboard

Published 20 hours ago • verified publisher icon guardian

`Card` uses a `picture` tag for images

Open oliverlloyd opened this issue 2 years ago • 3 comments

A picture tag is preferable to an img tag for lots of reasons. Now that DCR is able to create its own sources we have the flexibility to do better.

oliverlloyd avatar Apr 12 '22 13:04 oliverlloyd

Depends on #4752 for image optimisation

AshCorr avatar Apr 27 '22 10:04 AshCorr

Depends on https://github.com/guardian/dotcom-rendering/issues/5121

oliverlloyd avatar Jun 05 '22 14:06 oliverlloyd

Ahead of starting this work we need to refactor onwards such that we stop client side rendering Card. If we want this component to import and use Picture then it can only be executed on the server, where the salt is available.

oliverlloyd avatar Jul 11 '22 07:07 oliverlloyd

An alternative to using Picture is creating a component specifically for fronts: FrontPicture introduced in #6065

mxdvl avatar Oct 17 '22 09:10 mxdvl

Replaced by https://github.com/guardian/dotcom-rendering/issues/6062

oliverlloyd avatar Oct 17 '22 12:10 oliverlloyd