frontend icon indicating copy to clipboard operation
frontend copied to clipboard

Integer timestamps for newsletter tracking

Open dblatcher opened this issue 3 years ago • 4 comments

What does this change?

Uses integer timestamps on component events for newsletter sign-up components, instead of formatting into a custom date format. After a point raised in https://github.com/guardian/dotcom-rendering/pull/5440, which originally implemented the custom data format on a DCR component, it was realised that the formatting can be by the data team as their end, reducing the amount of client side code required.

Does this change need to be reproduced in dotcom-rendering ?

  • [x] No
  • [ ] Yes (please indicate your plans for DCR Implementation)

What is the value of this and can you measure success?

  • reduces JS payload for all newsletters page and sign-up iframes
  • will make the tracking format consistent with the new DCR component.

Checklist

Does this affect other platforms?

  • [ ] AMP
  • [ ] Apps
  • [ ] Other (please specify)

Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?

  • [x] No
  • [ ] Yes (please give details)

Does this change break ad-free?

  • [x] No
  • [ ] It did, but tests caught it and I fixed it
  • [ ] It did, but there was no test coverage so I added that then fixed it

Does this change update the version of CAPI we're using?

Accessibility test checklist

Tested

  • [x] Locally
  • [ ] On CODE (optional)

dblatcher avatar Jul 25 '22 10:07 dblatcher

"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days"

github-actions[bot] avatar Aug 25 '22 06:08 github-actions[bot]

This seems valuable, will you be merging it, @dblatcher?

mxdvl avatar Aug 25 '22 06:08 mxdvl

This seems valuable, will you be merging it, @dblatcher?

Yes, sorry. I was going to double check with the data team to make sure they were ready for the change

dblatcher avatar Aug 25 '22 14:08 dblatcher

As of 30th August, the data team wanted to do some more checks on their end to make sure this won't break any reporting.

dblatcher avatar Sep 12 '22 11:09 dblatcher

"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days"

github-actions[bot] avatar Oct 13 '22 06:10 github-actions[bot]

Seen on PROD (merged by @dblatcher 21 minutes and 55 seconds ago)

prout-bot avatar Oct 13 '22 08:10 prout-bot