Michael Voříšek

Results 434 comments of Michael Voříšek

Maybe some code from https://github.com/phpstan/phpstan-src/commit/0dbe3ab24dd40d6e291413aa64db5eca9f0f6d68#diff-3887df0457831e1b8fd86144e1d07a7737643885122108493625853be7f4a198R1299 can be reused.

It seems the types are defined in https://github.com/markstory/sphinxcontrib-phpdomain/blob/0.11.1/sphinxcontrib/phpdomain.py#L124 but not registered for other parsers like in this example: https://gist.github.com/shimizukawa/4498647#file-conf-py-L33 https://pydoc.dev/sphinx/latest/sphinx.directives.ObjectDescription.html?private=1#doc_field_types `doc_field_types` is not documented much here is docs for field:...

For classes I would also expect attributes like "extends", "implements", ex: ``` :::{php:class} Car :extends: ObjectModel :implements: JsonSerializable :implements: Iterator Car class that can be serialized to JSON and iterated....

I support this PR. When debug build is enabled, it does not make any sense to remove the sources. I understand the post from @tianon, but let's make developers live...

in popup it seems DOM element is wrapped in jQuery is passed too - https://github.com/fomantic/Fomantic-UI/blob/2.9.0/src/definitions/modules/popup.js#L359 it would be great if exact JSdoc could be added at least above all settings...

> Please see https://phpstan.org/blog/phpstan-1-9-0-with-phpdoc-asserts-list-type#describe-type-of-current-object-after-calling-a-method > > I think this might work Most of the nodes are `DOMElement`. It should work out of the box at least for level

Another repro: https://phpstan.org/r/f583e77c-d58c-4f08-a97e-dfb692acadf5 - it seems assign is affected as well if done in arrow closure.

Thank you. Did you look also in the completely wrong file name (instead of trait) reported (prior the fixes)?

Can you please clone https://github.com/atk4/core and run phpstan v1.11.0 on it. You should get the output as above, ie. line from trait, but with filename (wrongly) from the class.