php icon indicating copy to clipboard operation
php copied to clipboard

Do not delete source files when debugging

Open yyny opened this issue 6 months ago • 3 comments

yyny avatar Feb 19 '24 11:02 yyny

This "oh, but one more thing" is actually part of the reason why we resisted implementing DOCKER_PHP_ENABLE_DEBUG for so long :sweat_smile: :heart:

In this specific case, this is really trivial to implement via docker-php-source extract post-build, so without a stronger justification than "it'd be handy", I'm afraid this one is a likely decline. :bow:

tianon avatar Feb 20 '24 19:02 tianon

I support this PR. When debug build is enabled, it does not make any sense to remove the sources. I understand the post from @tianon, but let's make developers live not harder.

mvorisek avatar Feb 23 '24 12:02 mvorisek

docker-php-source extract wouldn't quite work for me because I am patching the sources.

yyny avatar Feb 23 '24 13:02 yyny