Matthieu Muffato

Results 66 comments of Matthieu Muffato

@FriederikeHanssen . I've merged the latest master and fixed the CI failures. I think all of your comments have now been addressed ?

Oh, I had missed the announcement on Slack, and was still trying to get all the existing PRs in. Of course, yes, let's wait 👍🏼

As in #1833 , don't use `NO_FILE` in nf-core modules.

Hi @nservant . Let's first do #1404 ? That'll make this PR cleaner

No worries, @JoseEspinosa , I should have added myself as a reviewer. I've got some questions / concerns about cload and dump, which I'll try to address in #1404 ....

@FriederikeHanssen @ramprasadn . The tests now pass, I think this is good for merging.

Hi @nservant Can you explain what you mean by "allow to run the cload and dump cooler functions across multiple resolutions" ? I don't see how that's not possible with...

I took a look at the tests, and there is an issue in `cooler/dump`. The module appends the resolution to the name of the input file, cf https://github.com/nf-core/modules/blob/ec22f9a9079bd93ff8ec152349ead5f684edeb9f/modules/cooler/dump/main.nf#L29 , which...

Hi. I actually now think it'd be easier to address these comments in #1937 since the latter contains these changes. I'll close this PR and reraise my comments over there.

Hi @jkbonfield . I much prefer the second solution: it looks more intuitive to me, but also provides the original sequence name as `PN`. Once a format is agreed, could...