Matthieu Muffato

Results 77 comments of Matthieu Muffato

Before I go back to #590, do you think this one (and #585) could be quickly wrapped up ? I think I answered everything except https://github.com/singularityhub/singularity-hpc/pull/589#discussion_r967857828

I've moved the cleanup call a level up into `_sync`

My bad as well. I should have noticed before committing the change

Yeah, the tests pass 😎 !

> One quick question - where does the ssh come in (have you tested and it works for you?) It still works. I've tried `shpc sync-registry`, `shpc show`, `shpc install`,...

I've added a SSH url to the tests. The changelog and version bump will have to happen in the parent PR: #585 , where the merge conflict with `main` has...

Hi. FYI I've got `shpc reinstall` and `shpc upgrade` working. The code is very fresh and rough and I want to work more on it, but the core is there.

I feel much more comfortable than when I started, and I think I understand the corner cases. Could you still please review the following ? That'll help me finish this...

> Can you show me what this would look like on the command line? E.g., right now we have: > > ```shell > shpc view install > $ shpc view...

> But to step back a second - views are symlinks. There isn't really a concept of reinstall that doesn't alter a view. We really should just be updating the...