Manu Sridharan

I see. I think this is in fact an argument for unifying the logic between these two handlers and only having one handler. Right now the code structure is quite...

Thanks @lazaroclapp! All sounds good to me. My only concern is the following: > This will imply regenerating `android-jarinfer-models-sdk*` for all the Android SDK versions we have historically supported (_and_...

I'd like to unblock this PR. I propose we go ahead and evolve the `astubx` format with fully-qualified types, and I will find a way to update the `android-jarinfer-models-sdk*` as...

Update here is that it's hard to get rid of `InferredJarModelsHandler` without first switching to fully-qualified types in `astubx` files. The logic [here](https://github.com/uber/NullAway/blob/b7756eaa0f28d88e09ad6a52a22d373e4a42ae56/nullaway/src/main/java/com/uber/nullaway/handlers/InferredJARModelsHandler.java#L97-L97) for looking up method parameter nullability strips...

NullAway supports custom `castToNonNull` methods, which cast a `@Nullable` expression to `@NonNull` ([docs](https://github.com/uber/NullAway/wiki/Suppressing-Warnings#downcasting)). The Checker Framework provides [similar methods](https://checkerframework.org/api/org/checkerframework/checker/nullness/util/NullnessUtil.html). This type of method is a useful alternative to `requireNonNull` since...

@cushon was curious if you had any thoughts on this approach and whether it's acceptable. Happy to do more cleanup if you feel it's needed before you can take a...

> I took a quick pass. I think this makes sense overall, I will try to do some internal testing. Sounds good! Let me know how things look after that.

@cushon this change is being successfully used at Uber to enable Error Prone auto-patching to work with Bazel, along with https://github.com/bazelbuild/bazel/pull/21640. I have a follow-on Error Prone fix that makes...

@cushon are any other steps required for this one to land? Thanks for the help!

This is a workaround: ```diff - return walk.flatMap( + return walk.flatMap( ```