Manu Sridharan

I should say a bit more here. This test case exposes a new issue on JDK 22+. On JDK 21 and earlier the issue with not reading type annotations from...

There is now a PR https://github.com/openjdk/jdk/pull/20460 up to fix this issue. Once a fix lands, it will have to get into a released JDK before NullAway users can benefit from...

Small update here. The above PR has landed and will ship with JDK 24. There is a backport for JDK 23: https://github.com/openjdk/jdk23u/pull/67 Assuming the backport goes through, I think this...

@gavlyukovskiy there is an effort to get related fixes for reading of type annotations from bytecodes backported to JDK 21 and possibly earlier. See https://github.com/jspecify/jspecify/issues/365, https://bugs.openjdk.org/browse/JDK-8323093, and https://mail.openjdk.org/pipermail/compiler-dev/2024-July/027344.html. At this...

I have confirmed that just-released JDK 23.0.2 contains the `javac` fix relevant to this issue. Leaving this issue open as should only close when it's fixed on all of NullAway's...

@bannmann this bug should be fixed in JDK 21.0.8 with the `-XDaddTypeAnnotationsToSymbol=true` compiler arg passed. I updated the [JSpecify support wiki page](https://github.com/uber/NullAway/wiki/JSpecify-Support) accordingly. I'll go ahead and close this issue;...

Hi @vorburger! Short answer: I think it shouldn't be too hard to write a `LibraryModels` implementation that just parsed external annotations and then returned the right nullability info from its...

Couple of quick observations here. ``` /Users/ben/projects/caffeine/caffeine/src/main/java/com/github/benmanes/caffeine/cache/Caffeine.java:333: warning: [NullAway] passing @Nullable parameter 'this.executor' where @NonNull is required requireState(this.executor == null, "executor was already set to %s", this.executor); ``` This is...

> > This is a false positive due to https://github.com/uber/NullAway/issues/674. > > > > It is expected that this would show up only when JSpecify mode is enabled or it...

I wanted to summarize some thoughts and issues on how to move forward with this PR, to possibly get some help. As part of #950, we need a way to...