Manu Sridharan

Results 671 comments of Manu Sridharan

There is also https://github.com/ucr-riple/NullAwayAnnotator, which has been used to enroll millions of lines of code onto NullAway at Uber. /cc @lazaroclapp @yuxincs @nimakarimipour

> * I think https://github.com/uber/NullAway/blob/master/jar-infer/jar-infer-cli/README.md is somewhat different, but the NullAway folks may have pointers, and so may other people inside and outside the group. This is more about inferring...

Related: #706 And see also: https://github.com/uber/NullAway/issues/708#issuecomment-1830051031

This issue is fixed in JDK 24-ea, but most likely we should still implement a workaround in NullAway.

From my testing, it looks like this is also fixed in the latest JDK 23 release candidate. FYI @cpovirk

This issue diagnosed the problem incorrectly; see #1266.

Hi @gavlyukovskiy, one caveat is that our JSpecify mode checks are still limited. That said I think your specific test case should work. You may be running into https://github.com/uber/NullAway/issues/1005. Any...

This is very interesting, thanks for reporting. I can reproduce the problem, even on JDK 22, and I've pushed a test case [here](https://github.com/msridhar/NullAway/commit/4d8a0a162529df97c3efba90d7567abf8312734b). This to me looks like a bug...

FWIW, here is what I see for the `withFunction` method when I run `javap -v` on the class file: ``` public static void withFunction(java.util.function.Function); descriptor: (Ljava/util/function/Function;)V flags: (0x0009) ACC_PUBLIC, ACC_STATIC...

@gavlyukovskiy I've confirmed this is an issue in javac. I'll put updates here as there is progress towards a fix.