Sean Gilligan

Results 510 comments of Sean Gilligan

`Wallet_setting.fxml` is not a backup but a JavaFX interface description file. **bitcoinj** is a library, not a supported wallet application, so I strongly recommend it not be used for storage...

PR #3103 Uses a slightly different implementation than suggested above to address issues (1) and (2) above, but does not address issue (3).

PR #3101 was closed in favor of PR #3129, which has been merged.

Let's leave it open for at least another few days and I'll probably defer it to 0.18, but also open a new smaller issue for 0.17 and maybe create a...

Next task for me after the Bech32 stuff is to go after these remaining uses of `NetworkParameters`. Note that this patch set does not verify a lack of external dependencies...

This is a good start for thinking about this. I will sleep on it. One thought: maybe we are approaching this "bermuda triangle" from the wrong direction. We've been trying...

> Generally I like the idea of `Connected` extends `Unconnected`. > > I wonder if having an interface for `TransactionOutPoint` is perhaps overkill – will we ever have other impls?...

> > I wonder if having an interface for `TransactionOutPoint` is perhaps overkill – will we ever have other impls? > > … We should probably make the container an...

One thing we should probably clarify is that by "our network stack" what we really mean is our library for _Peer_ networking. This is the bulk of networking code in...

To answer your two questions: > 1. Do we still need blocking I/O? I heard it's needed for Tor, but I don't understand the details. I'm a little weak on...