Sean Gilligan
Sean Gilligan
I submitted draft PR #2315 (with a total of 19 jobs!) and this error did not occur -- though 3 others did. Maybe should try re-running it a few times....
Here is the failure with Gradle 7.3.3 and the Microsoft JDK17: https://github.com/msgilligan/bitcoinj/runs/5440185303?check_suite_focus=true
Current status: ``` for (( ; ; )) ; do gradle bitcoinj-core:cleanTest bitcoinj-core:test --tests org.bitcoinj.wallet.DeterministicKeyChainTest ; done ```
> If comparing the "expected" and the "but was" parts, the only difference is the `i` in "issued_subkeys" is replaced by `ı`, the dotless `i`. When I look at the...
I took a look at the `checkSerialization` method and made a PR to clean it up a little bit: https://github.com/bitcoinj/bitcoinj/pull/2317 Other than moving code into methods, it should not change...
> Current status: > > ``` > for (( ; ; )) ; do gradle bitcoinj-core:cleanTest bitcoinj-core:test --tests org.bitcoinj.wallet.DeterministicKeyChainTest ; done > ``` I'm having a hard time reproducing the...
This one seems to have disappeared!
PR #3085 is a new PR that is based on this PR. Please review.
It's probably failing unit tests because it's no longer building the special UNITEST block as `network` for the UNITEST `NetworkParameters` is `REGTEST`.
Concept ack, though. (Although this could also come after PR #3135 is merged.)