Noeri Huisman
Noeri Huisman
Not sure, I wasn't able reproduce the issue in a plain A-Frame project. Placing a break point in `updateProperties` in `component.js`, reveals that after calling `.setAttribute` there are two updates:...
Oh... found it. It's related to the fact that the example scene has `debug="true"`. This forces the `flushToDOM` logic on every update. The `stringify` method for assets is just the...
@vincentfretin It seems that the master builds aren't being updated any more (Notice the last commit date here: https://github.com/aframevr/aframe/tree/master/dist). While the build bot still makes changes and commits, it doesn't...
@vincentfretin Found the bug, there's indeed an edge case when "unsetting" a value. These are now recorded as `undefined` on the internal `attrValue`, which behaves virtually identical to an empty...
The problem isn't so much that the `EffectComposer` renders into its own render target, but more that it renders the final output to the screen (or WebXR swapchain texture). It...
Indeed, we shouldn't be modifying built-in components for this. There should be a clean way to replace the main render call of the scene ([scene.js#L667](https://github.com/aframevr/aframe/blob/6a497bf4d274b713dd6d81b7e6fc5a0e87015dd5/src/core/scene/a-scene.js#L667)), so that this hack in...
Thanks :-) The `UnrealBloomEffect` is modelled after the `UnrealBloomPass` of three.js. It performs a luminance threshold to determine which pixels contribute to the bloom. This is done on an HDR...
If the goal is to reduce the bundle size, there are bigger fish to fry. You can use a source map explorer to get an idea, but things like [switching...
> since pmndrs/xr does not do anything in regards to threejs layers, I'd assume this is a problem that also occurs in vanilla threejs. This issue does not happen in...
> [@mrxz](https://github.com/mrxz) yes that is true, but why would that make a difference? If the layers of cameraXR are not changed somewhere, they should be the same then a new...