Matthew Roeschke
Matthew Roeschke
> no tests needed updating? Looks like there was no existing test so added one
Thanks for the feedback everyone. For the pandas implementation, I changed our sentinel to use the integer representation of `pd.NaT`
Thanks @mattB1989
This may be working as expected if I am looking at your csv file correctly. As the docs state: > Specifies what to do upon encountering a bad line (a...
> @mroeschke do you prefer the kind of test I suggested to no test? Yeah your suggested test would be good too add, thanks.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and...
Yeah I think maintaining logic for a `pyarrow behavior -> pandas behavior` for csv parsing (not just date parsing) is going to be a very large undertaking. I think the...
If this was an issue in `test_round_sanity` as suggested in https://github.com/pandas-dev/pandas/issues/47933#issuecomment-1205909274, we did xfail(strict=False) this test in https://github.com/pandas-dev/pandas/pull/47803
Still needed?
Thanks for confirming. In any case, a check can be made in a follow up