Matthew Roeschke comments

Results 465 comments of


                                            Matthew Roeschke

ENH: Support For Interval contains Other Interval (#46613)

Thanks @kapiliyer!

Added improvements in to_datetime Error reporting message - incorrect field today/now shown in error

Thanks @dannyi96

BUG: #47350 if else added to add NaT for missing time values

Please review https://pandas.pydata.org/pandas-docs/stable/development/contributing_codebase.html#contributing-to-the-code-base for instructions on how to submit a pull request so that the team understands the changes

BUG: #47350 if else added to add NaT for missing time values

From the logs, it appears your code change broke existing unit tests https://github.com/pandas-dev/pandas/runs/7309922086?check_suite_focus=true

BUG: #47350 if else added to add NaT for missing time values

Ideally all tests should still be passing even when the code fix is made.

BUG: #47350 if else added to add NaT for missing time values

You can just push your changes to the same pull request as Github will show the code changes relative to the latest commit. You can read more about a successful...

BUG: #47350 if else added to add NaT for missing time values

Appears you will need to merge in the main branch too.

BUG: #47350 if else added to add NaT for missing time values

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and...

Use CMake for Build System

I'd be supportive of trying CMake. Generally hoping 1. Not too much deviations across platforms Linux/MacOS/Windows 2. Near identical setup & invocation for local development & CI system